Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 22.04 to CI #1801

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Add Ubuntu 22.04 to CI #1801

merged 2 commits into from
Jun 21, 2022

Conversation

JonasVautherin
Copy link
Collaborator

@potaito: FYI

@JonasVautherin
Copy link
Collaborator Author

JonasVautherin commented Jun 8, 2022

Here, curl finds openssl on the system (which we don't expect for the superbuild):

2022-06-08T22:17:01.1231890Z -- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.2")  

Which does not make sense to me since curl is build with:

2022-06-08T22:16:51.2657444Z -- Preparing external project "curl" with args:
2022-06-08T22:16:51.2658220Z -- -- -DCMAKE_INSTALL_PREFIX:PATH=/home/runner/work/MAVSDK/MAVSDK/build/release/third_party/install

And OpenSSL was built and installed there right before:

2022-06-08T22:16:50.3145344Z install libcrypto.pc -> /home/runner/work/MAVSDK/MAVSDK/build/release/third_party/install/lib/pkgconfig/libcrypto.pc
2022-06-08T22:16:50.3184326Z install libssl.pc -> /home/runner/work/MAVSDK/MAVSDK/build/release/third_party/install/lib/pkgconfig/libssl.pc
2022-06-08T22:16:50.3222658Z install openssl.pc -> /home/runner/work/MAVSDK/MAVSDK/build/release/third_party/install/lib/pkgconfig/openssl.pc

I could imagine that the FindOpenSSL.cmake changed on Ubuntu 22.04, but that does not tell me why @julianoes changes in #1797 work 🤔.

Ideas?

@julianoes
Copy link
Collaborator

but that does not tell me why @julianoes changes in #1797 work thinking.

My changes don't work.

@JonasVautherin
Copy link
Collaborator Author

It does build on a docker ubuntu:22.04 container. I don't get what's different here 🤔

@JonasVautherin
Copy link
Collaborator Author

JonasVautherin commented Jun 20, 2022

So it finds OpenSSL in the system when building CURL, which is unexpected (it should find the one from our deps):

Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.2")

For re2 it finds ours:

Found OpenSSL: /home/runner/work/MAVSDK/MAVSDK/build/release/third_party/install/lib/libcrypto.a (found version "1.1.1o")

Same for mavlink and mavsdk_server:

Found OpenSSL: /home/runner/work/MAVSDK/MAVSDK/build/release/third_party/install/lib/libcrypto.a (found version "1.1.1o")

I just realized that the third_party deps don't propagate CMAKE_PREFIX_PATH... I believe they should, I just don't understand why we never had an issue before 😅.

EDIT: actually we had it for grpc and protobuf, just curl was missing it. I guess we always got lucky with the OpenSSL version on the system being compatible with ours...

@JonasVautherin
Copy link
Collaborator Author

@julianoes @potaito: I think that was it 😊

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@julianoes julianoes merged commit f591625 into main Jun 21, 2022
@julianoes julianoes deleted the ci-add-ubuntu-20.04 branch June 21, 2022 06:53
@potaito
Copy link
Contributor

potaito commented Jun 21, 2022

Thanks for the digging @JonasVautherin, I appreciate it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants