-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu 22.04 to CI #1801
Add Ubuntu 22.04 to CI #1801
Conversation
Here, curl finds openssl on the system (which we don't expect for the superbuild):
Which does not make sense to me since curl is build with:
And OpenSSL was built and installed there right before:
I could imagine that the Ideas? |
My changes don't work. |
It does build on a docker |
a4a5c01
to
c7d729e
Compare
So it finds OpenSSL in the system when building CURL, which is unexpected (it should find the one from our deps):
For re2 it finds ours:
Same for mavlink and mavsdk_server:
I just realized that the EDIT: actually we had it for grpc and protobuf, just curl was missing it. I guess we always got lucky with the OpenSSL version on the system being compatible with ours... |
c7d729e
to
3dc63b1
Compare
@julianoes @potaito: I think that was it 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Thanks for the digging @JonasVautherin, I appreciate it!! |
@potaito: FYI