Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister to prevent fulfilling promise twice #1824

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

JonasVautherin
Copy link
Collaborator

Not sure if that was this one here, since I would have expected to see "Waiting to discover vehicle" in the logs. But I would expect even more log output for the next ones, so... 😅

@JonasVautherin JonasVautherin requested a review from julianoes June 28, 2022 21:20
@JonasVautherin JonasVautherin force-pushed the improve-integration-test branch from bb59fd2 to 6350a73 Compare June 28, 2022 23:03
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, seems about right.

@julianoes julianoes merged commit 582b0d3 into main Jun 30, 2022
@julianoes julianoes deleted the improve-integration-test branch June 30, 2022 13:43
@julianoes julianoes added the bug label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants