core: Fixed unnecessary repeated invocations of notify_on_discover
#2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problem introduced in v2.10.1 Now it works only if there was a change in the connection status
JonasVautherin
changed the title
notify_on_discovernotify_on_discover
JonasVautherin
previously approved these changes
Jul 23, 2024
|
JonasVautherin
approved these changes
Jul 23, 2024
julianoes
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Yep, that looks about right! Thanks for fixing this @fibonacci-matrix!
|
I will have to create a 2.12 branch and backport it there, as main is now already on the way towards v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem introduced in v2.10.1
Now it works only if there was a change in the connection status
closes: #2354