hotfix(TimetableController): handle no route patterns #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
approved these changes
Mar 5, 2025
| [] | ||
| end) | ||
|
|
||
| assert build_timetable(conn, @schedules) |
There was a problem hiding this comment.
Non-blocking: Is there a way to make a non-trivial relevant empty-state assertion for this use case? Like that it pulls a route pattern from somewhere else, or that it has a reasonable empty state (empty list, "No route pattern exists you bozo" string, or something like that?)
There was a problem hiding this comment.
Yeah... a followup to test the "no trips here" version of the page will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timetable logic assumes canonical route patterns exist for every route. When that doesn't happen to be the case, we should gracefully handle that. This PR stops
Enum.EmptyErrorfrom ruining everything, by setting an initial accumulator forEnum.reduce/3!The test is a little silly at this point but it did help me clearly see the fail vs success state!