fix(Android): update location with hide maps on #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
approved these changes
Mar 3, 2025
|
|
||
| @OptIn(ExperimentalMaterial3Api::class, ExperimentalTestApi::class) | ||
| @Test | ||
| fun testHideMapsLocationUpdates() { |
There was a problem hiding this comment.
🙌 Nice work adding a test!
the ViewportProvider constructor does not, in fact, return Unit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Android | Fix hide maps location getting stuck
I was going to feel bad for leaving this out in #621, but I didn't, it's right there, it got removed in #622. Presumably it was a merge conflict thing, since those PRs have adjacent numbers.
iOS
[ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?[ ] Add temporary machine translations, marked "Needs Review"android
[ ] All user-facing strings added to strings resource in alphabetical order[ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possibleTesting
Manually verified that this issue is not present on iOS. Manually checked that this issue is now fixed on Android. Added a test.