Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notes about async versions of filesystemsyncaccesshandle methods #28814

Conversation

chrisdavidmills
Copy link
Contributor

Description

As detailed in #28647, the notes that mention this are wrong; the incorrect async versions of these methods are no longer supported in any modern browser. This PR fixes those notes as suggested.

Motivation

Additional details

Related issues and pull requests

Fixes #28647

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner August 29, 2023 09:24
@chrisdavidmills chrisdavidmills requested review from wbamberg and removed request for a team August 29, 2023 09:24
@github-actions github-actions bot added the Content:WebAPI Web API docs label Aug 29, 2023
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris! I had an annoying nitpicky comment, which is that these notes don't really belong in the Examples section - the best place for them IMO would be at the end of the preamble, just before ## Syntax.

But I won't insist on it.

What do you think?

@chrisdavidmills
Copy link
Contributor Author

Thanks Chris! I had an annoying nitpicky comment, which is that these notes don't really belong in the Examples section - the best place for them IMO would be at the end of the preamble, just before ## Syntax.

But I won't insist on it.

What do you think?

Cheers @wbamberg; this is a reasonable comment. I have moved all of them as suggested where the note is directly relevant to the subject of the page, but I've left a couple as-is, in cases where the note really just relates to content of the example itself.

@chrisdavidmills chrisdavidmills merged commit 37cafbf into mdn:main Sep 5, 2023
@chrisdavidmills chrisdavidmills deleted the ammend-filesystemsyncaccesshandle-async-info branch September 5, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileSystemSyncAccessHandle is all synchronous, docs say it's sometimes async
2 participants