Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1634 - remove old compat site for zh-CN and zh-TW #1899

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

SphinxKnight
Copy link
Member

This removes occurrences where necessary and delete partly translated/unmaintained pages. See #1634 for rationale

@SphinxKnight SphinxKnight requested a review from a team as a code owner August 4, 2021 16:33
@SphinxKnight SphinxKnight requested review from t7yang and removed request for a team August 4, 2021 16:33
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Aug 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

Preview URLs

Flaws

URL: /zh-CN/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 for developers
on GitHub
Flaw count: 3

  • macros:
    • /zh-CN/docs/Web/API/BasicCardRequest/supportedTypes does not exist but fallbacked on /en-US/docs/Web/API/BasicCardRequest/supportedTypes
  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#JavaScript_types
    • Can't resolve /en-US/docs/Web/Guide/Events/Mutation_events

URL: /zh-CN/docs/Mozilla/Firefox/Releases/78
Title: 对于开发人员的Firefox 78
on GitHub
Flaw count: 11

  • macros:
    • /zh-CN/docs/Web/JavaScript/Reference/RegExp redirects to /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/RegExp
    • /zh-CN/docs/Web/JavaScript/Reference/WeakMap redirects to /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/WeakMap
    • /zh-CN/docs/Web/API/ParentNode/replaceChildren does not exist but fallbacked on /en-US/docs/Web/API/Element/replaceChildren
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • and 3 more flaws omitted

URL: /zh-CN/docs/Mozilla/Firefox/Releases/59
Title: Firefox 59 for developers
on GitHub
Flaw count: 12

  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor#HTML_preview
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector#Cookies
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Rulers
    • Can't resolve https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode
    • and 4 more flaws omitted
  • sectioning:
    • Excess <h2> tag that is NOT at root-level (id='Web平台的删减', text='Web平台的删减')
    • Excess <h2> tag that is NOT at root-level (id='Mozilla和附加组件开发者应该注意的变化', text='Mozilla和附加组件开发者应该注意的变化')
    • Excess <h2> tag that is NOT at root-level (id='参见', text='参见')

URL: /zh-CN/docs/Web/API/Element/keyup_event
Title: Element: keyup event
on GitHub
Flaw count: 2

  • macros:
    • unable to find an HTML element with an "id" of "addEventListener_keyup_example" within /zh-CN/docs/Web/API/Element/keyup_event
  • translation_differences:
    • Differences in the important macros (2 in common of 5 possible)

URL: /zh-CN/docs/Web/API/Element/keydown_event
Title: Element: 键盘按下事件
on GitHub
Flaw count: 2

  • macros:
    • unable to find an HTML element with an "id" of "addEventListener_keydown_example" within /zh-CN/docs/Web/API/Element/keydown_event
  • translation_differences:
    • Differences in the important macros (2 in common of 5 possible)

URL: /zh-CN/docs/Web/API/Navigator/buildID
Title: Navigator.buildID
on GitHub
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /zh-CN/docs/Web/API/Worker
Title: Worker
on GitHub
Flaw count: 17

  • macros:
    • /zh-CN/docs/Web/API/ChromeWorker does not exist
    • /zh-CN/docs/Web/API/AbstractWorker does not exist but fallbacked on /en-US/docs/Web/API/Worker
    • /zh-CN/docs/Web/API/AbstractWorker/onerror does not exist but fallbacked on /en-US/docs/Web/API/Worker/onerror
    • /zh-CN/docs/Web/API/AbstractWorker does not exist but fallbacked on /en-US/docs/Web/API/Worker
    • /zh-CN/docs/Web/API/DedicatedWorkerGlobalScope/postMessage does not exist but fallbacked on /en-US/docs/Web/API/DedicatedWorkerGlobalScope/postMessage
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API
    • Can't resolve https://developer.mozilla.org/zh-CN/docs/Web/API/Web_Workers_API/Functions_and_classes_available_to_workers
    • Can't resolve /en/DOM/XMLHttpRequest
    • Can't resolve /zh-CN/docs/Mozilla/js-ctypes
    • Is currently http:// but can become https://
    • and 3 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 4 possible)

External URLs

URL: /zh-CN/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 for developers
on GitHub


URL: /zh-CN/docs/Mozilla/Firefox/Releases/78
Title: 对于开发人员的Firefox 78
on GitHub


URL: /zh-CN/docs/Mozilla/Firefox/Releases/59
Title: Firefox 59 for developers
on GitHub

No new external URLs


URL: /zh-CN/docs/Web/API/Element/keyup_event
Title: Element: keyup event
on GitHub

No new external URLs


URL: /zh-CN/docs/Web/API/Element/keydown_event
Title: Element: 键盘按下事件
on GitHub

No new external URLs


URL: /zh-CN/docs/Web/API/Navigator/buildID
Title: Navigator.buildID
on GitHub

No new external URLs


URL: /zh-CN/docs/Web/API/Worker
Title: Worker
on GitHub

No new external URLs

Copy link
Collaborator

@irvin irvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the MR affected and remove the release notes for developers?

@SphinxKnight
Copy link
Member Author

Hello @irvin, I went with deleting pages which were partly translated. (If I may copy what I wrote on #1897 (comment)) :

"I went with deleting pages which were mostly untranslated as those generally tend to be unmaintained pages. Moreover when a reader arrives on such a page there are often mixed-feelings about the quality of the doc.

If having partly translated pages was a natural outcome of the previous platform (kuma), under Yari/git, I think they should be updated completely or deleted.

Let me know if you have a plan for such updates, I'm not against reverting those deletions, I thought this was the best default course of actions."

@t7yang t7yang removed their request for review August 5, 2021 15:12
@irvin irvin merged commit 9b2427e into mdn:main Aug 5, 2021
@SphinxKnight SphinxKnight deleted the fix1634-zh branch February 23, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants