Multiple views from command line #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were asked if we could try to solve #218 so I did a quick attempt to correct it.
You should now be able to open different files in different containers using for example:
However, it raises some questions/problems...
I only changed the behavior of the open(QString file) method. The open(medDataIndex) method should probably be able to do the same. Moreover, we can open images from various places (medMainWindow, medApplication, medAbstractWorkspace...), We should probably try to limit the number of possibilities and probably find a way to allow the opening in a new container...and be able to handle multiple openings form the browser, as Mike was saying in #220 .
In the next few days I have, I will try to focus on process refactoring, so if someone wants to take this over, please go ahead.