Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid global scope styles #30

Merged
merged 1 commit into from
May 31, 2022
Merged

fix: avoid global scope styles #30

merged 1 commit into from
May 31, 2022

Conversation

Durss
Copy link
Contributor

@Durss Durss commented May 30, 2022 •
edited
Loading

The following styles are declared in the global scope which may conflict with the app using this component as they have quite
generic names:

  • overlay
  • marquee
  • transparent-overlay

I've forced them under the vue3-marquee scope to make sure they don't interfer with the global scope.

@vercel
Copy link

vercel bot commented May 30, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vue3-marquee ✅ Ready (Inspect) Visit Preview May 30, 2022 at 4:21PM (UTC)

@megasanjay megasanjay self-requested a review May 31, 2022 09:27
megasanjay
megasanjay approved these changes May 31, 2022
View reviewed changes
Copy link
Owner

@megasanjay megasanjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must somehow have forgotten to scope the css.

This is a great suggestion! Thank you.

@megasanjay megasanjay changed the title Avoid global scope styles fix: avoid global scope styles May 31, 2022
@megasanjay megasanjay merged commit d51c105 into megasanjay:main May 31, 2022
megasanjay pushed a commit that referenced this pull request May 31, 2022
fix: avoid global scope styles #30
dad4899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megasanjay megasanjay megasanjay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Durss @megasanjay