-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for google vector search - (matching engine) #2177
Added support for google vector search - (matching engine) #2177
Conversation
Hey @anchit-nishant Can you please resolve the merge conflicts and so then we can review the PR? |
Hey @Dev-Khant |
Hey @anchit-nishant I think we got a new merge conflict because of a PR was merged, can you please resolve it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be good to call it vertex_ai_search
?
Merged. Vertex AI Search is a an end to end search solution from GCP, where as Vertex AI Vector Search (earlier called as Matching Engine) is a Vector Database provided by GCP. We are using Vector Search (Matching Engine) here |
Got it, thanks for clarifying. Then we should name it as |
Updated the code with "vertex_ai_vector_search" nomenclature. The Google API refers it as MatchingEngine hence kept the core functions same. Merged and tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @anchit-nishant Thanks for making the change with the name. Can you please add tests for the this new vector_store and also rebase with main as there is a merge conflict? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anchit-nishant LGTM. Thanks for the contribution!
Description
Adding support for google vector search (matching engine).
m.add | m.get | m.get_all | m.update | m.search | m.history | m.delete |
Type of change
How Has This Been Tested?
Manual testing. with below parameters.
"vector_store": {
"provider": "google_matching_engine",
"config": {
"endpoint_id": "XXXXXXXXXXXXXXXXXXX",
"index_id": "XXXXXXXXXXXXXXXXXXX",
"deployment_index_id": "abc_XXXXXXXXXXXXX",
"project_id": "",
"project_number": "XXXXXXXXXXXX",
"region": "us-central1",
"vector_search_api_endpoint": "XXXXXXXXX.us-central1-XXXXXXXXXXXX.vdb.vertexai.goog"
}
Checklist:
Maintainer Checklist