-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLATFORM-562] feat: Implement connectors commands #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c1552f
to
ed35401
Compare
d929905
to
8bc712e
Compare
dc0aa3c
to
c1af420
Compare
7 tasks
10 tasks
lovromazgon
reviewed
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of suggestions, but all in all, I'm quite happy with the PR, I think the structure is nice and clear.
Co-authored-by: Lovro Mažgon <[email protected]>
Co-authored-by: Lovro Mažgon <[email protected]>
lovromazgon
reviewed
Apr 30, 2021
lovromazgon
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Nicely done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes https://meroxa.atlassian.net/browse/PLATFORM-562.
This pull request contains all commands related to connectors while also migrating them to use the new builder process adding tests to some commands that didn't have them before.
The idea to ultimately release this will be with the use of
MEROXA_V2
env variable.example:
export MEROXA_V2=only
would make only v2 commands to be availableunset MEROXA_V2
would leave the CLI as v1 only.export MEROXA_V2=any_value
would make both v1 and v2 commands coexist. We could decide to remove this restriction once we're feature complete on v2.Type of change
How was this tested?
Demo
Before this pull-request
After this pull-request
Additional references
Design document