Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLATFORM-676] feat: Set actor on whoami #146

Merged
merged 1 commit into from
May 27, 2021
Merged

[PLATFORM-676] feat: Set actor on whoami #146

merged 1 commit into from
May 27, 2021

Conversation

raulb
Copy link
Member

@raulb raulb commented May 27, 2021 •
edited
Loading

Description of change

Fixes https://meroxa.atlassian.net/browse/PLATFORM-676

Starts writing on file / memory (for tests mainly) ACTOR and ACTOR_UUID towards using this information for emitting metrics on commands usage.

  • It also implements config on builder automatically writing on file

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

Before this pull-request

❯ .m env
Using meroxa config located in "/Users/rb/Library/Application Support/meroxa/config.env"

access_token: eyJhbGc...JRuUKjQ
refresh_token: ab_c6CD...n54qWoS

After this pull-request

❯ .m whoami
[email protected]

❯ .m env
Using meroxa config located in "/Users/rb/Library/Application Support/meroxa/config.env"

access_token: eyJhbGc...JRuUKjQ
actor: [email protected]
actor_uuid: my-uuid
refresh_token: ab_c6CD...n54qWoS

@raulb
feat: Set actor on whoami
fc9bd24 
- It also implements config on builder automatically writing on file
@raulb raulb requested a review from lovromazgon May 27, 2021 14:04
lovromazgon
lovromazgon approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new CommandWithConfig ❤️

@raulb raulb merged commit c3456bd into master May 27, 2021
@raulb raulb deleted the raul/add-actor-to-env branch May 27, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulb @lovromazgon