Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLATFORM-594] [PLATFORM-595] [PLATFORM-741] Add SSH Tunnel commands #148

Merged
merged 4 commits into from
Jun 8, 2021

Conversation

owenthereal
Copy link
Contributor

@owenthereal owenthereal commented Jun 2, 2021

Description of change

Add tunnel creation, update, list, and describe. This depends on https://github.com/meroxa/meroxa-go/pull/40. The meroxa resources describe layout is changed to accommodate the ssh tunnel display.

Fixes https://meroxa.atlassian.net/browse/PLATFORM-594
Fixes https://meroxa.atlassian.net/browse/PLATFORM-595
Fixes https://meroxa.atlassian.net/browse/PLATFORM-596

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

$ m resources create tunnel --type postgres -u DB_URL --ssh-url SSH_TUNNEL_ADDR
$ m resources update tunnel --type postgres -u DB_URL --ssh-url SSH_TUNNEL_ADDR
$ m resource list
  ID      NAME       TYPE                                              URL                                             SSH TUNNELED
====== ========== ========== ======================================================================================== ==============
   11   resource   postgres   postgres://...                                                                               False
 1091   tunnel     postgres   postgres://...                                                                               True
$ m resource describe tunnel
Resource tunnel
================
    ID:   1091
  NAME:   tunnel
  TYPE:   postgres
   URL:   postgres://...
 Status   error

SSH tunnel public key for SSH_TUNNEL_ADDR
=========================================
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDP9j0HfeHKDXAoExDpAdplUq0BYDQsIikXkwA3SvEUhYLmliMyZvAXrQQLTlVORdcYPMlFSFILlsPjC58gzwLhfjyi0s+jqNpMaHz4ALu+VazU9zGJmG6TJVF+Vh9Xqvmxe8/v9wucOPyyXTeGkg26BWCfT3YmdCtNrnbbCfl8b83qZg/vhO/rok9+RfpyyVZDwGRXmzHPlSe4h/hp+qb/dqTEh+9KEdO2kKQ7BX5chbcxHuQ9Yu1ul9iKEYi4PBg4F/uzbr7pgXq9CykC+mwG/F0oJeyL2JVhCbKlvXsLIEkTUK2OhbixEfBoSeDDoCidTmd76i4ZM0tvkeHUBbeoIz8SWTF8gVUrxgJCurP+2Wz9IaJYPceemElgztigOFGjvlFvAZG7UT9crB25xTSJ3RAEeZbT8uoPCefkqQ1VGqnMC8jkqHWSOS6KY+en/EBwd+/f77uNlQiBbxWB3iC2NBnshN0lTNfeHV68oezoxfADH06CUpLU7E/3kRKOXVCZwQbuO0NRwmX392IMEmCH32XSps/jcKJ/6bosrfs3iLrj03+qiZXug7tzzn/da36EMmoBrwqW6FDX25BfB7wJX7xUFdT5uXD15Si9hhmSWdmvMYQNVUmHRxZtfqcVfAY99NCT72yCMLLKvEj09a3TG7IzX4Tm1lTRDShdDsgeIQ==

Documentation updated

Not right now until this feature is officially released.

@owenthereal owenthereal requested review from raulb and dianadoherty June 2, 2021 19:47
@owenthereal owenthereal changed the title Add SSH Tunnel commands [PLATFORM-594] [PLATFORM-595] [PLATFORM-741] Add SSH Tunnel commands Jun 2, 2021
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some questions regarding the output formatting and wether we should hide certain things such as flag, and SSH_TUNNELED column until we release this to everyone.

@owenthereal
Copy link
Contributor Author

@raulb This is ready to be reviewed again

Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor tweak on confirmation message on resource creation.

I'm slightly concerned this could be automatically documented in a next build, but it sounds like it could be ok.

@owenthereal owenthereal merged commit 67c6867 into master Jun 8, 2021
@owenthereal owenthereal deleted the ssh_tunnel branch June 8, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants