-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLATFORM-594] [PLATFORM-595] [PLATFORM-741] Add SSH Tunnel commands #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got some questions regarding the output formatting and wether we should hide certain things such as flag, and SSH_TUNNELED
column until we release this to everyone.
@raulb This is ready to be reviewed again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor tweak on confirmation message on resource creation.
I'm slightly concerned this could be automatically documented in a next build, but it sounds like it could be ok.
Description of change
Add tunnel creation, update, list, and describe. This depends on https://github.com/meroxa/meroxa-go/pull/40. The
meroxa resources describe
layout is changed to accommodate the ssh tunnel display.Fixes https://meroxa.atlassian.net/browse/PLATFORM-594
Fixes https://meroxa.atlassian.net/browse/PLATFORM-595
Fixes https://meroxa.atlassian.net/browse/PLATFORM-596
Type of change
How was this tested?
Demo
Documentation updated
Not right now until this feature is officially released.