Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apps init (updates to latest turbine-go) #335

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

raulb
Copy link
Member

@raulb raulb commented Apr 25, 2022

Description of change

Fixes the following error by upgrading to latest turbine-go.

$ meroxa apps run
# order-go-app
./app.go:64:18: too many arguments in call to dest.Write
	have (turbine.Records, string, nil)
	want (turbine.Records, string)
Error: build failed

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

Demo

Before

Seen error above.

After

The following works just as expected:

$ meroxa apps init;meroxa apps run

@raulb raulb self-assigned this Apr 25, 2022
@raulb raulb added the bug Something isn't working label Apr 25, 2022
@raulb raulb merged commit ede43ee into master Apr 25, 2022
@raulb raulb deleted the raul/fix-apps-init branch April 25, 2022 15:32
@@ -288,7 +288,7 @@ func GoInit(ctx context.Context, l log.Logger, appPath string, skipInit, vendor
if err != nil {
return err
}
depsLog := "Downloading dependencies "
depsLog := "Downloading dependencies"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was intentional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants