Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include dev info on meroxa version #341

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

raulb
Copy link
Member

@raulb raulb commented Apr 29, 2022

Description of change

Fixes #340

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

Demo

Before

$ make install
$ meroxa version
meroxa/dev darwin/amd64

After

$ make install
$ meroxa version
meroxa/dev:7abf3288 v2.0.0-alpha.3-1-g7abf3288 darwin/amd64

If a change was made on top of a commit:

$ meroxa version
meroxa/dev:7abf3288 v2.0.0-alpha.3-1-g7abf3288 (updated) darwin/amd64

If it was built from same source as a tag:

$ meroxa version
meroxa/dev:7abf3288 v2.0.0-alpha.3 darwin/amd64

Note: Demo was shared in slack if you still need more info.

@raulb raulb self-assigned this Apr 29, 2022
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


func main() {
global.Version = version
global.Version = fmt.Sprintf("%s:%s %s %s", version, GitCommit, GitLatestTag, GitUntracked)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super neat!

Copy link
Contributor

@ericcheatham ericcheatham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@raulb raulb merged commit 662e3c9 into master May 3, 2022
@raulb raulb deleted the raul/include-info-cli-dev branch May 3, 2022 15:03
Copy link
Contributor

@janelletavares janelletavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is so much smaller than I thought it would be! nice

@raulb raulb mentioned this pull request May 3, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose git sha or tag when built from source
4 participants