Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide clarity on how the init command and dashboard interact #349

Merged
merged 1 commit into from
May 12, 2022

Conversation

janelletavares
Copy link
Contributor

Description of change

Customers may not immediately understand that the init command doesn't make any API calls and the dashboard won't show the app yet

Fixes https://github.com/meroxa/turbine-project/issues/246

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

@janelletavares janelletavares requested review from a team, nassor and ericcheatham and removed request for a team May 10, 2022 14:18
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a question about including apps describe --extended. Aside from that, this should be good!

@raulb raulb merged commit 69bfba1 into master May 12, 2022
@raulb raulb deleted the dashboard-warning branch May 12, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants