Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Creating GitHub CI Workflow for Cli #360

Merged
merged 4 commits into from
May 27, 2022
Merged

chore: Creating GitHub CI Workflow for Cli #360

merged 4 commits into from
May 27, 2022

Conversation

JuanP3rAlta23
Copy link
Contributor

@JuanP3rAlta23 JuanP3rAlta23 commented May 23, 2022 •
edited by simonl2002
Loading

Fixes #353

@JuanP3rAlta23 JuanP3rAlta23 linked an issue May 23, 2022 that may be closed by this pull request
Covert Circleci config file to a Github Actions workflow #353
Closed
@JuanP3rAlta23 JuanP3rAlta23 self-assigned this May 23, 2022
raulb
raulb requested changes May 24, 2022
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Just ran into this PR and wanted to leave some comments while you're working on it. Let me know if you have any questions!

@raulb raulb changed the title Creating Github CI Workflow for Cli chore: Creating GitHub CI Workflow for Cli May 24, 2022
@JuanP3rAlta23 JuanP3rAlta23 requested a review from raulb May 26, 2022 14:03
raulb
raulb requested changes May 26, 2022
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanP3rAlta23 looking good! Some comments before we can ship this one.

@JuanP3rAlta23 JuanP3rAlta23 force-pushed the migrate_cicleci_githubactions branch from 6fb9e24 to 45895b5 Compare May 26, 2022 15:23
@JuanP3rAlta23 JuanP3rAlta23 force-pushed the migrate_cicleci_githubactions branch from 45895b5 to 4a215ea Compare May 26, 2022 15:58
@JuanP3rAlta23 JuanP3rAlta23 requested a review from raulb May 26, 2022 18:13
raulb
raulb approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanP3rAlta23 looks great! nice work!

@JuanP3rAlta23 JuanP3rAlta23 merged commit 7ab985b into master May 27, 2022
@JuanP3rAlta23 JuanP3rAlta23 deleted the migrate_cicleci_githubactions branch May 27, 2022 15:22
@JuanP3rAlta23 JuanP3rAlta23 mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

@alsidneio alsidneio Awaiting requested review from alsidneio

@bjones519 bjones519 Awaiting requested review from bjones519

@simonl2002 simonl2002 Awaiting requested review from simonl2002

Assignees

@JuanP3rAlta23 JuanP3rAlta23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Covert Circleci config file to a Github Actions workflow
2 participants
@JuanP3rAlta23 @raulb