Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate uuid requests #98

Merged
merged 2 commits into from
Apr 13, 2023
Merged

validate uuid requests #98

merged 2 commits into from
Apr 13, 2023

Conversation

mikemrm
Copy link
Contributor

@mikemrm mikemrm commented Apr 12, 2023

validates url path param uuid is valid, otherwise returns a bad request if an invalid uuid is provided

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #98 (ca6c3cb) into main (e47b818) will increase coverage by 0.18%.
The diff coverage is 68.57%.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   74.66%   74.84%   +0.18%     
==========================================
  Files          10       10              
  Lines         971      994      +23     
==========================================
+ Hits          725      744      +19     
- Misses        198      202       +4     
  Partials       48       48              
Flag Coverage Δ
unittests 74.84% <68.57%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/v1/router_instance_metadata.go 68.09% <62.50%> (+0.89%) ⬆️
pkg/api/v1/router.go 86.66% <70.00%> (-1.34%) ⬇️
pkg/api/v1/router_responses.go 79.71% <77.77%> (-0.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mikemrm mikemrm marked this pull request as ready for review April 12, 2023 23:47
@mikemrm mikemrm requested a review from a team April 12, 2023 23:47
@mikemrm mikemrm merged commit eb141da into main Apr 13, 2023
@mikemrm mikemrm deleted the validate-uuid branch April 13, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants