Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fix broken IPAM kustomization links in releasing.md #2357

Merged

Conversation

peppi-lotta
Copy link
Member

What this PR does / why we need it: Change IPAM links to pass link check. These wiles no longer exist in main but are relevant for release branch.

Signed-off-by: peppi-lotta <[email protected]>
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.9 milestone Feb 27, 2025
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/retitle 📖 Fix broken IPAM kustomization links in releasing.md

@metal3-io-bot metal3-io-bot changed the title 🐛 Fix broken links 📖 Fix broken IPAM kustomization links in releasing.md Feb 27, 2025
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@adilGhaffarDev
Copy link
Member

/lgtm
/override metal3-centos-e2e-integration-test-release-1-9

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2025
@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: Overrode contexts on behalf of adilGhaffarDev: metal3-centos-e2e-integration-test-release-1-9

In response to this:

/lgtm
/override metal3-centos-e2e-integration-test-release-1-9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 7716f39 into metal3-io:release-1.9 Feb 27, 2025
16 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/fix-ipam-links-1.9 branch February 27, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants