Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Prepare for jquery 3 #299

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

sebakerckhof
Copy link
Contributor

@sebakerckhof sebakerckhof commented Nov 14, 2019

// XXX No `String.trim` on Safari 4. Swap out $.trim if we want to
// remove strong dep on jquery.
tokens.append(match[1], match[0].trim ? match[0].trim() : $.trim(match[0]));
tokens.append(match[1], match[0].trim());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ecmascript package should take care of this through core-js.

Copy link
Contributor

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@benjamn benjamn merged commit f13c2ad into meteor:master Nov 15, 2019
benjamn pushed a commit to meteor/meteor that referenced this pull request Nov 15, 2019
This version of Blaze includes meteor/blaze#299 by
@sebakerckhof, which is an important prerequisite for #10498.
sebakerckhof pushed a commit to sebakerckhof/meteor that referenced this pull request Nov 25, 2019
This version of Blaze includes meteor/blaze#299 by
@sebakerckhof, which is an important prerequisite for meteor#10498.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants