Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RethinkDb.Test.Integration.GroupingTests fail under Microsoft .NET 4.5 on Windows #133

Closed
mfenniak opened this issue Sep 20, 2013 · 1 comment
Assignees
Labels

Comments

@mfenniak
Copy link
Owner

Apparently the GroupingTests fail in Windows w/ .NET; they throw exceptions at line 66 of TupleDatumConverterFactory.cs stating that the "object" type does not have a ConvertDatum method. I believe the cause of this is that anonymous types are considered internal, and therefore can't be recognized by the dynamic keyword in this context.

One fix would be to rewrite ReflectedConversion to use reflection, rather than dynamic. I think that might work.

Another fix would be to add non-generic IDatumConverter instances, and the use of dynamic in TupleDatumConverterFactory could be removed. However, this is a large change affecting a lot of code, particularly the complex DataContractDatumConverterFactory.

@mfenniak
Copy link
Owner Author

Confirmed fixed in Windows; all unit tests now pass in Windows.

mfenniak added a commit that referenced this issue Sep 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant