Support multi-indexes in IndexDefine #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only GetAll supports multi-indexes; EqJoin also should for sure, and I'm not sure if any other operations are supported on multi-indexes.
Reduces duplication in query operations that support both multi-indexes and single-indexes without any difference in type signature.
mfenniak
added a commit
that referenced
this pull request
Oct 21, 2014
Support multi-indexes in IndexDefine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #163 closed with improved index support, multi-indexes weren't included in that issue, so, here's this one instead. This requires identifying where multi-indexes behave differently than normal indexes (eg. GetAll). The index is defined on an array, but queried on individual elements. A different interface will need to be created and additional methods added to Query to support type-safe multiindex access.
TableTests.IndexCreateMulti should be cloned and used with the new type-safe approach.