Switch to the maintained pytest-lazy-fixtures package #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Jul 8, 2024
tests/test_field.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| import pytest | |||
| from django.core.exceptions import ValidationError | |||
| from pytest_lazyfixture import lazy_fixture | |||
| from pytest_lazy_fixtures import lf | |||
There was a problem hiding this comment.
Given that lf is a bit cryptic (is it linefeed?) what about...
Suggested change
| from pytest_lazy_fixtures import lf | |
| from pytest_lazy_fixtures import lf as lazy_fixture |
and then revert all the remaining changes in this file.
tests/test_form_field.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| import pytest | |||
| from django import forms | |||
| from pytest_lazyfixture import lazy_fixture | |||
| from pytest_lazy_fixtures import lf | |||
There was a problem hiding this comment.
Suggested change
| from pytest_lazy_fixtures import lf | |
| from pytest_lazy_fixtures import lf as lazy_fixture |
and then revert all the remaining changes in this file.
tests/test_model_form_field.py
Outdated
| @@ -1,5 +1,5 @@ | |||
| import pytest | |||
| from pytest_lazyfixture import lazy_fixture | |||
| from pytest_lazy_fixtures import lf | |||
There was a problem hiding this comment.
Suggested change
| from pytest_lazy_fixtures import lf | |
| from pytest_lazy_fixtures import lf as lazy_fixture |
and then revert all the remaining changes in this file.
`pytest-lazy-fixture` has not been maintained since 2022, and it does not work properly with pytest-8 anymore [1]. Switch to the maintained `pytest-lazy-fixtures` replacement. [1] TvoroG/pytest-lazy-fixture#65
|
Sure, updated now. |
cclauss
approved these changes
Jul 8, 2024
|
Thanks very much for the contribution! Not sure why Github isn't running CI for this, but I ran the test locally and all looked good. Merging. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-lazy-fixturehas not been maintained since 2022, and it does not work properly with pytest-8 anymore. Switch to the maintainedpytest-lazy-fixturesreplacement.I've split poetry lock update to a separate commit, in case you preferred it done some other way.