Use precise dependency versions in Cargo.toml #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the advice from [1], this PR updates Cargo.toml to use precise version numbers for all dependencies. The latest versions at the time of writing are used. It turns out that we made precisely the mistake mentioned in the post: ``` % cargo -Z minimal-versions update % cargo test ``` failed on nightly because of the dependency on smawk 0.3: we need 0.3.1 after #421. [1]: https://users.rust-lang.org/t/psa-please-specify-precise-dependency-versions-in-cargo-toml/71277
mgeisler
force-pushed
the
precise-dep-version-numbers
branch
from
5986a90 to
55c1aa4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the advice from the Rust forum, this PR updates Cargo.toml to use precise version numbers for all dependencies. The latest versions at the time of writing are used.
It turns out that we made precisely the mistake mentioned in the post:
failed on nightly because of the dependency on smawk 0.3: we need 0.3.1 after #421.