Partition Column_Value by geoid #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterrrock2 this is ready for review with the change to partition on column_id |
peterrrock2
approved these changes
Feb 2, 2025
Comment on lines
+32
to
+33
| SCHEMA = "gerrydb" | ||
| metadata_obj = MetaData(schema=SCHEMA) |
There was a problem hiding this comment.
What's the reason for this change? It's not a big deal, I am just curious
There was a problem hiding this comment.
we use SCHEMA to generate the partition sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add table partitioning to the column_value table on column_id in the hopes of reducing row counts when querying.
@peterrrock2 - I don't have strong feelings where the utility function for generating the partition DDL lives, I stuck in a utils file because it seemed out of place elsewhere but very open to feedback on that and everything else.