Fixes typescript build failure comparing null | undefined #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mhamas I came across an issue deploying this today, so I've made a patch for you.
The key issue is that in
node_modules/apify/types/proxy_configuration.d.ts
, we have:Meaning
proxyConfigurationObject
is maybenull
:But in
node_modules/apify/types/crawlers/puppeteer_crawler.d.ts
, we have:Which means it could be set or
undefined
, but notnull
:The nullish-colleasing patch means if it's
null
, we make itundefined
to keep TS happy.Turning:

into:
