gencache fix: compare against keys rather than values in ForgetAboutTypelibInterface
#2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che-fix-ForgetAboutTypelibInterface
Avasam
changed the title
ForgetAboutTypelibInterface
Avasam
commented
Oct 18, 2024
…che-fix-ForgetAboutTypelibInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by pyright's
reportUnnecessaryComparisonIf
versionRedirectMap's keys are tuples, and values are Modules, this comparison made no sense and "drop any version redirects to it" was never done. If I'm correct, this probably fixes some gencache / typelib issue, but I have no idea which (there's a handful open), or will cause issues if this behaviour not working was fine for 21 years.Writing a unit test for the intended behaviour might be warranted. @mhammond please advise.