Restore shipping help file #2432
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Nov 19, 2024
Avasam
commented
Nov 19, 2024
|
"but it worked on my machine!"... (and I tried to make sure to test from clean installs !) It's also annoyingly basically the same error as in #2392 |
Avasam
commented
Jan 7, 2025
…m/pywin32 into restore-shipping-help-file
…re-shipping-help-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores shipping help file to the users by including its build in the setuptools build, rather than it being a separate manual step as before.
This also means that we should theorically be able to update the online doc from GitHub artifacts instead of downloading/installing from PyPI. (I think that'll require merging the workflow files though).
If you'd like that, I can merge the workflows in this PR.