Fix bad format IID in VTableItem.WriteVTableMap #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Fix-bad-format-IID-in-VTableItem.WriteVTableMap
branch
from
c9f705d to
1e5aa05
Compare
Avasam
force-pushed
the
Fix-bad-format-IID-in-VTableItem.WriteVTableMap
branch
from
1e5aa05 to
b45f557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNTESTED !!!
But it makes sense to me, repr in repr will cause
IIDto be stringified, and strings to double up on quotes.Not sure how to add tests for this.
Closes #714