Added two new fuctions to dict API #63
Conversation
pdfio-dict.c
Outdated
| // | ||
|
|
||
| size_t // O - Number of keys | ||
| pdfioDictGetNumKeys(pdfio_dict_t *dict) // I - Dictionary |
There was a problem hiding this comment.
Should be pdfioDictGetNumPairs.
pdfio-dict.c
Outdated
| // | ||
| // Alternative form to enumerate the keys of a dictionary | ||
|
|
||
| bool // O - Value |
There was a problem hiding this comment.
Should return the key string.
There was a problem hiding this comment.
The problem that I see only returning a string with the key It is that also It is of interest get the type with the save call. That left return as void or as bool.
There was a problem hiding this comment.
There is already a function to get the type associated with a key. Alternately you could have a pdfio_valtype_t * argument that (optionally) returns the type in the pointed variable. Returning the results via a struct pointer and separately returning a bool doesn't make a lot of sense.
pdfio-dict.c
Outdated
| { | ||
| if (key){ | ||
| key->key = dict->pairs[index].key; | ||
| key->type = (pdfio_valtype_t **)(dict->pairs[index].value.type); |
There was a problem hiding this comment.
dist->pairs[index].value.type is a literal pdfio_valtype_t value, not a pointer or pointer to pointer...
There was a problem hiding this comment.
It is the way in that I manage to recall the value itself among the key string pointer.
There was a problem hiding this comment.
That doesn't make any sense. pdfio_valtype_t is an enum (integer). You aren't returning the address of the enum, you are casting the enum value to a pointer which isn't valid.
pdfio.h
Outdated
| @@ -123,6 +123,12 @@ typedef enum pdfio_valtype_e // PDF value types | |||
| PDFIO_VALTYPE_NUMBER, // Number (integer or real) | |||
| PDFIO_VALTYPE_STRING // String | |||
| } pdfio_valtype_t; | |||
| // Alternative PDF dict key enumeration | |||
| typedef struct pdfio_dictKey_s | |||
|
I'm not a full time programmer (only for hobby and some times for solve something in the work) and It is also my first "pull request" (also again in a very rudimentary way). The reason for this two functions It is no need the use of a callback for each time that review for a dictionary keys. |
pdfioDictGetNumKeys -> pdfioDictGetNumPairs
pdfioDictGetKeyByIndex:
- only return the key string and then only return a const char *
test_mod.c:
- changed to contemplate the requested modification
Add pdfioArrayRemove and pdfioDictClear APIs (Issue #74)
Hello,
I have added two new functions to iterate a dictionary without the use of a callback. I have also include a test purpose file.
Feel free to correct the changes. I think that are usefull.
P.D.: Sorry, I see in the commit that I have include the "test_mod" executable. Delete it.
Thanks.