Fix mounting for inputs container #642
Conversation
| var valuesString = KubernetesYaml.Serialize(values); | ||
| await File.WriteAllTextAsync(TempHelmValuesYamlPath, valuesString); | ||
| await Deployer.UploadTextToStorageAccountAsync(storageAccount, Deployer.ConfigurationContainerName, "aksValues.yaml", valuesString, cts.Token); | ||
| } | ||
|
|
||
| private void UpdateValues(HelmValues values, Version previousVersion) |
There was a problem hiding this comment.
Seems like this method should be named something like "UpdateContainerValues", and then in the Deployer.cs, there is a version check in the Update area, which would result in calling this. That way it's very clear what happens during an update, not buried in KubernetesManager.cs
There was a problem hiding this comment.
My intention was that all version related updates to the helm values would be added to this method not just this example for containers. I renamed the method to ProcessHelmValuesUpdates though, and passed the installedVersion from the deployer so hopefully its a little clearer.
| {{- range .Values.internalContainersMIAuth }} | ||
| {{- $path := printf "/%s/%s" .accountName .containerName }} | ||
| {{- $claimName := printf "%s-%s-claim1" .accountName .containerName }} | ||
| {{- if eq $storageAccount .accountName }} | ||
| {{- if and (eq $storageAccount .accountName) (has .containerName $cromwellContainers)}} |
There was a problem hiding this comment.
is this case insensitive?
There was a problem hiding this comment.
It is not, there is no case insensitive comparison in the helm template language from what I can tell. I converted the strings to lowercase for comparison now though.
|
@jsaun can you please link the original issue and/or update the title and description of this PR? |
No description provided.