Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WDL glob test #645

Merged
merged 6 commits into from
Apr 24, 2023
Merged

Add WDL glob test #645

merged 6 commits into from
Apr 24, 2023

Conversation

MattMcL4475
Copy link
Contributor

@MattMcL4475 MattMcL4475 commented Apr 23, 2023

This new integration test executes a WDL that creates three files, then uses the WDL https://github.com/openwdl/wdl/blob/main/versions/1.0/SPEC.md#globs to upload them. When running in a test environment, this workflow succeeded in Cromwell, and the three output files were successfully uploaded.

@MattMcL4475
Copy link
Contributor Author

This results in three output files in the virtual directory test/b2d2179a-3860-4ad5-a9e8-f08b5e90c0e3/call-globtest/execution/glob-ef5df339533c1334f081dc8cc75ee4f3/
image
image

@MattMcL4475 MattMcL4475 requested a review from a team April 24, 2023 00:54
Copy link
Contributor

@ashanhol ashanhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. interesting we're manually trimming the '?' off the sas token, not sure how the token's added to run the test but I wonder if a method like my fix would make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants