Support for shared external AKS cluster #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsaun Please add an issue for this. |
jsaun
changed the title
BMurri
approved these changes
Aug 18, 2023
|
|
||
| if (!string.IsNullOrWhiteSpace(configuration.AksClusterName) && !configuration.UsePostgreSqlSingleServer) | ||
| { | ||
| throw new Exception("If providing an existing AKS cluster, --UsePostgreSqlSingleServer must be set to true."); |
There was a problem hiding this comment.
Isn't single server being retired in 19 months?
There was a problem hiding this comment.
We'll see, you still can't create private endpoint to a flexible postgres server. So if postgres is in our vnet and our services are running in AKS in another vnet, there's no good way to connect. We'd have to set postgres to public, or peer the vnets both of which are aren't ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Networking fixes:
If a preexisting AKS cluster is supplied, query for the vnet it belongs to, create the postgresql PE to that vnet, and use the associated private dns zone if it exists.
Namespace Fixes:
Storage classes and persistent volume claims are not namespaced objects in Kubernetes. This prepends a namespace to the required objects to avoid conflicts in the case that multiple CoA instances are deployed into different namespaces on the same AKS cluster (customer ran into this need). Fixes #683