Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PostresSingleServer and improve deployer reliability #744

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

BMurri
Copy link
Collaborator

@BMurri BMurri commented Dec 15, 2023

fixes #743
Requires microsoft/ga4gh-tes#552 as a prerequisite.

@BMurri BMurri requested review from jsaun and MattMcL4475 December 15, 2023 01:56
@jsaun
Copy link
Contributor

jsaun commented Dec 15, 2023

I would prefer to wait to remove single server until private link for flexible server is GA. https://learn.microsoft.com/en-us/azure/postgresql/flexible-server/concepts-networking-private-link . Providence is still using single server and won't switch to flexible until the private networking is GA.

@jsaun
Copy link
Contributor

jsaun commented Dec 15, 2023

That said, Providence is mostly a custom deployment already so I'm sure they could continue using single server regardless of what we do in our deployer, but it does make it that much harder to replicate their deployment ourselves.

@BMurri
Copy link
Collaborator Author

BMurri commented Dec 15, 2023

This doesn't force a switch. Current deployments with single serve should still upgrade correctly without changing/removing/dropping support for them. It just won't enable new deployments with single server Postgres.

@jsaun
Copy link
Contributor

jsaun commented Dec 15, 2023

We could also have another organization with similar networking requirements and azure policies around private preview features want to deploy CoA, but I suppose we can always point them to an older version.. Its probably fine, I'm a just a bit more risk adverse in terms of removing functionality.

@BMurri BMurri merged commit c662e60 into main Dec 15, 2023
@BMurri BMurri deleted the bmurri/more-deployer-cleanup branch December 15, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for new deployments with Postgres single server
3 participants