[SPIRV] Inline ray tracing doesn't compile

[Jasper-Bekkers]

RaytracingAccelerationStructure g_topLevel : register(t0, space0);
RWTexture2D<float4> g_output : register(u1, space0);

[numthreads(64, 1, 1)]
void main(uint2 launchIndex: SV_DispatchThreadID)
{
    float3 T = (float3)0;
    float sampleCount = 0;
    RayDesc ray;

    ray.Origin = float3(0, 0, 0);
    ray.Direction = float3(0, 1, 0);
    ray.TMin = 0.0;
    ray.TMax = 1000.0;

    RayQuery<RAY_FLAG_FORCE_OPAQUE> q;

    q.TraceRayInline(g_topLevel, 0, 0xff, ray);
    q.Proceed();

    if(q.CommittedStatus() == COMMITTED_TRIANGLE_HIT)
    {
        T += float3(1, 0, 1);
    }
    else 
    {
        T += float3(0, 1, 0);
    }

    g_output[launchIndex] += float4(T, 1);
}

Output with -spirv:

>dxc -spirv -Tcs_6_5 repro.hlsl /Zi -Qembed_debug
repro.hlsl:18:5: warning: SPV_KHR_ray_query is currently a provisional extension and mightchange in ways that are not backwards compatible
    q.TraceRayInline(g_topLevel, 0, 0xff, ray);
    ^
repro.cs.hlsl:19:5: warning: SPV_KHR_ray_query is currently a provisional extension and mightchange in ways that are not backwards compatible
    q.Proceed();
    ^
repro.hlsl:21:8: warning: SPV_KHR_ray_query is currently a provisional extension and mightchange in ways that are not backwards compatible
    if(q.CommittedStatus() == COMMITTED_TRIANGLE_HIT)
       ^
fatal error: found unregistered decl
note: please file a bug report on https://github.com/Microsoft/DirectXShaderCompiler/issues with source code if possible

Output when compiling normally:

>dxc -Tcs_6_5 repro.hlsl /Zi -Qembed_debug
;
; Note: shader requires additional functionality:
;       Typed UAV Load Additional Formats
;       Raytracing tier 1.1 features

...

[dgkoch]

cc @jiaolu are you able to look at this? cc @Tobski

[jiaolu]

okay, i will take a look

[alelenv]

Is the issue enums like COMMITTED_TRIANGLE_HIT not being present in astDecls before use?
I think adding to getDeclEvalInfo is not correct and you should add them in doImplicitDecl similar to other enums for ray tracing

[ehsannas]

yeah I agree. @jiaolu please consider and update your PR accordingly. Thanks!

[jiaolu]

doImplicitDecl

I did add them in the doImplicitDecl
I tried to remove spvContext.isLib() || spvContext.isRay(), but it would break the tests like WholeFileTest.PassThruPixelShader
in clang-spirv-tests.exe . the astcontext would add the dcl regardlessly for the all shader without raytracing shader guarding.

[ehsannas]

Fixed via #3054