-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template type on struct breaks this
pointer (hlsl-2021)
#3732
Comments
@tcorringham You may be interested in this |
@j-dahl Is CS_6_0 supporting template function? Why does my following implementations failed to compile?
I am using runtime API instead of dxc.exe like this:
Is it possible to pass |
@ghostplant at the moment template support is very experimental and requires you to be on a separate branch (and have |
Thanks, can you estimate when template-supported DXC can be ported into Visual Studio's SDK plugin? Currently I found that generating all-type functions is painful. |
Prior to this change explicit `this` access inside a struct was treated as a reference, but implicit `this` was still a pointer type. With this change `this` is always a reference type. This has no impact on code generation since references and pointers all digress to addresses, but it does make the AST more accurately reflect the types and it resolves microsoft#3732.
* Make `this` more consistently a reference type Prior to this change explicit `this` access inside a struct was treated as a reference, but implicit `this` was still a pointer type. With this change `this` is always a reference type. This has no impact on code generation since references and pointers all digress to addresses, but it does make the AST more accurately reflect the types and it resolves #3732. * Updating test case to handle incorrect operator
* Make `this` more consistently a reference type Prior to this change explicit `this` access inside a struct was treated as a reference, but implicit `this` was still a pointer type. With this change `this` is always a reference type. This has no impact on code generation since references and pointers all digress to addresses, but it does make the AST more accurately reflect the types and it resolves microsoft#3732. * Updating test case to handle incorrect operator
* Make `this` more consistently a reference type Prior to this change explicit `this` access inside a struct was treated as a reference, but implicit `this` was still a pointer type. With this change `this` is always a reference type. This has no impact on code generation since references and pointers all digress to addresses, but it does make the AST more accurately reflect the types and it resolves #3732. * Updating test case to handle incorrect operator
Regular structs with
this
in their methods (with access through the.
operator) do work, however, once a template argument is introduced DXC yields this error message:dxc -Tcs_6_6 -Emain -enable-templates test_bindless.hlsl
The text was updated successfully, but these errors were encountered: