Enable no-invalid-this ESLint rule and pre-apply fixes #10279
Conversation
github-actions
bot
added
the
area: tests
|
For the packages in which we're disabling the new rule, should we leave comments about why / future work to re-enable? |
Addressed in a separate PR: #10272 (comment) |
tylerbutler
changed the title
| // eslint-disable-next-line @typescript-eslint/no-invalid-this | ||
| Object.defineProperty(this, "__fluidTestProvider", { get: () => provider }); | ||
| }); | ||
| // eslint-disable-next-line @typescript-eslint/no-invalid-this | ||
| tests.bind(this)((reset: boolean = true) => { |
There was a problem hiding this comment.
@microsoft/fluid-cr-test Do you know whether these are bugs?
There was a problem hiding this comment.
I have not fully understood how this works in all cases yet. But I know Mocha sets this to some context object in some cases/ways, and it appears in the parameter list (but I don't think callers pass it - this is the part I don't totally get). so I think someone could explain why this is correct. If this were not correct none (ish) of our tests would pass.
From the documentation on the rule:
Disabled for tests and PropertyDDS projects.