Fix issues with EnumerateVersionsAsync not handling 404s #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when implementing version 0.1.346 of OSSGadget that our unit tests for package versions that don't exist would fail, as
var packageVersionExistence = await projectManager.DetailedPackageVersionExistsAsync(purl);
would throw anHttpRequestException
where theStatusCode
isHttpStatusCode.NotFound
.I would expect this case to return a
PackageVersionNotFound
instance ofIPackageExistence
instead of throwing a 404.This PR adds:
to each
ProjectManager
's implementation ofEnumerateVersionsAsync
.