Support environment variable overrides in package managers #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfs
approved these changes
Nov 11, 2022
|
@jaylindquist In order to accept your contribution you either need to accept the CLA per the bot or if you are a Microsoft employee you can associate your GitHub account with the organization. Thanks |
|
I'm waiting on my legal department to sign off on the CLA. I'll update the PR again once I have that |
|
@microsoft-github-policy-service agree [company="Target"] |
|
@microsoft-github-policy-service agree company="Target" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds environment variable overrides for package managers. The wiki documentation implies that this works for tools like
oss-downloadby adding aMAVEN_ENDPOINTenvironment variable, but the code did not support it.Additionally, there is a change to the Maven package manager to download jars that do not have javadoc or source jars available. Previously, if one or both jars were missing the actual jar would not be downloaded as an exception was encountered and the loop exited early