Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to NpmPackageManager to fime the time at which the first package version is created. #460

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Add method to NpmPackageManager to fime the time at which the first package version is created. #460

merged 4 commits into from
Mar 21, 2024

Conversation

morended
Copy link
Contributor

@morended morended commented Mar 18, 2024 •
edited
Loading

This PR adds:

  1. Method to NpmProjectManager class to fetch the package created time which is the time when the first package version is published.
  2. Added unit tests to verify it.

@morended morended force-pushed the morended/get-pacakge-created-time branch from 37e8bb1 to 73915d5 Compare March 19, 2024 20:56
@morended morended force-pushed the morended/get-pacakge-created-time branch from 6ee3093 to 86f682e Compare March 20, 2024 20:50
pmalmsten
pmalmsten approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@pmalmsten pmalmsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@jpinz jpinz merged commit 8727247 into microsoft:main Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfs gfs gfs approved these changes

@pmalmsten pmalmsten pmalmsten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morended @gfs @pmalmsten @jpinz