Alazar remove AlazarParameter support #1184
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1184 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 74 74
Lines 8456 8456
=======================================
Hits 6136 6136
Misses 2320 2320 |
jenshnielsen
changed the title
|
@astafan8 I have tested this with the Alazar 9360 driver. I updated the Alazar 9360 notebook slightly and removed the out of date notebook. There is certainly a lot more work that can be done on the Alazar drivers. I would prefer to do that in the next pr. It would be great if you can test this with the other cards. There is a 9870 notebook which is still out of date. That one should be deleted or updated to use the current api as part of this pr I think |
|
@jenshnielsen Great! i'm going to test it on 9870 and 9373, update the notebook. all the other possible driver improvements, let's, indeed, defer to other PRs. |
|
@jenshnielsen tested successfully on 9870 and 9373, haven't noticed anything wrong. i think, it's ready for merging. |
|
what is |
|
It's leftover. It contained nothing useful that was not in the other notebook so I deleted it |
Merge: 35c9928 6c7d4a0 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1184 from jenshnielsen/alazar_drop_alazar_parameter
This is only to be merged once we are happy with #1183 and sure that we do not need to still support the Alazar paramter. This still keeps the deprecated Config function