-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal hound a few more changes #1318
Merged
jenshnielsen
merged 7 commits into
microsoft:master
from
jenshnielsen:signal_hound_more_cleanup
Dec 5, 2018
Merged
Signal hound a few more changes #1318
jenshnielsen
merged 7 commits into
microsoft:master
from
jenshnielsen:signal_hound_more_cleanup
Dec 5, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These matches the calling conventions from the headers
Recursively call the code rather than duplication and store directly into numpy arrays
Codecov Report
@@ Coverage Diff @@
## master #1318 +/- ##
=======================================
Coverage 73.24% 73.24%
=======================================
Files 85 85
Lines 9833 9833
=======================================
Hits 7202 7202
Misses 2631 2631 |
astafan8
reviewed
Oct 15, 2018
astafan8
reviewed
Oct 15, 2018
astafan8
approved these changes
Oct 16, 2018
@jenshnielsen merge this if it's ready? |
@nataliejpg confirms that this is working |
giulioungaretti
pushed a commit
that referenced
this pull request
Dec 5, 2018
Merge: b0ccc03 747ce3d Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1318 from jenshnielsen/signal_hound_more_cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to resolve a usb comm error for @nataliejpg I cleaned up the driver a bit
_get_sweep_data
to capture data directly into a numpy array saving a loop over the data_get_sweep_data
removing the avg function. This saves a few redundant dll calls_get_sweep_data
. The api docs are quite clear that there is no point in retrying when the communication is lost. The only way forward is to close the device. All other errors relate to invalid input and will not be fixed by retrying