Driver/awg5014 upload lomentum sequence #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WG5014C_dictionary_input
…-Vogel/Qcodes into driver/AWG5014C_dictionary_input
Dominik-Vogel
requested review from
jenshnielsen,
astafan8 and
WilliamHPNielsen
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
=======================================
Coverage 73.24% 73.24%
=======================================
Files 85 85
Lines 9832 9832
=======================================
Hits 7201 7201
Misses 2631 2631 |
|
@QCoDeS/core can we merge this driver? All tests are still passing, I tried it out with the new name of the pulse-building lib and the upload still works. This PR only introduces a new function that does not interfere with the rest of qcodes. |
WilliamHPNielsen
approved these changes
Nov 21, 2018
…-Vogel/Qcodes into driver/AWG5014C_dictionary_input
giulioungaretti
pushed a commit
that referenced
this pull request
Nov 30, 2018
Merge: d20647c 8825cdd Author: Dominik Vogel <[email protected]> Merge pull request #1381 from Dominik-Vogel/driver/AWG5014C_dictionary_input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the capability to use forged sequences from the lomentum pulse buidling library with the AWG5014.
This driver does not create any dependency but makes a conditional import.
@QCoDeS/core all tests are passing. I would like to merge this pr so folks can start using lomentum.