feat: add specs for model '33512B' in KeysightAgilent_33XXX #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1422 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 85 85
Lines 9946 9946
=======================================
Hits 7386 7386
Misses 2560 2560 |
WilliamHPNielsen
approved these changes
Dec 21, 2018
|
It felt like a good occasion to go through the PR process. Thanks for reviewing. |
giulioungaretti
pushed a commit
that referenced
this pull request
Dec 21, 2018
Merge: 005d58e b597a64 Author: William H.P. Nielsen <[email protected]> Merge pull request #1422 from PoggioLab/extension/Keysight_33XXX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends Qcodes/qcodes/instrument_drivers/Keysight/KeysightAgilent_33XXX.py
Changes proposed in this pull request:
no_of_channelsandself._max_freqsdictionaries@jenshnielsen @WilliamHPNielsen