Feature/rigol dg1062/adding duty cycle parameter #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typofix: changed 'NOR' to 'NORM', so it works
typofix requesting period of burst mode
Addition: Added pulse waveform to waveforms
Addition: Added pulse waveform to waveforms
Some of the waveform functions are replied with a different name than needed to set that function, hence a translation dictionary is necessary.
Code cleanup: -Removing unnecessary spaces -Re-aligning get and set in functions
astafan8
requested changes
Jan 28, 2019
There was a problem hiding this comment.
Thanks! also for fixing the typo-driven bugs.
There are some minor style/readability/usability comments and crucial syntax error to fix.
Please, after all the changes, could to test the driver again with the actual instrument, and explicitly confirm that it's working?
After that, we'll merge.
Changed: Enhanced readability at certain points Moved the 'comma' Added more info around duty_cycle parameter Thanks for all the useful feedback!
Codecov Report
@@ Coverage Diff @@
## master #1456 +/- ##
=======================================
Coverage 73.78% 73.78%
=======================================
Files 92 92
Lines 10439 10439
=======================================
Hits 7702 7702
Misses 2737 2737 |
astafan8
approved these changes
Feb 28, 2019
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 1, 2019
Merge: 1cb3776 00a360f Author: Mikhail Astafev <[email protected]> Merge pull request #1456 from vhartong/feature/rigol_dg1062/adding_duty_cycle_parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: