Add support for exporting variable len array data to pandas #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1508 +/- ##
==========================================
+ Coverage 73.81% 73.82% +0.01%
==========================================
Files 92 92
Lines 10434 10438 +4
==========================================
+ Hits 7702 7706 +4
Misses 2732 2732 |
astafan8
approved these changes
Mar 5, 2019
| @@ -878,10 +878,22 @@ def get_data_as_pandas_dataframe(self, | |||
| elif len(keys) == 2: | |||
| index = pd.Index(subdict[keys[1]].ravel(), name=keys[1]) | |||
There was a problem hiding this comment.
a side question, is it guaranteed by self.get_parameter_data that keys[0] == name?
There was a problem hiding this comment.
Yes the first element is always the dependent data
Co-Authored-By: jenshnielsen <[email protected]>
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 6, 2019
Merge: 002c6e8 fd52339 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1508 from jenshnielsen/pandas_variable_len_arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.