Update logger docs #1517
Merged
Update logger docs #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dominik-Vogel Could you have a look at this since you wrote most of the logging module |
Codecov Report
@@ Coverage Diff @@
## master #1517 +/- ##
=======================================
Coverage 70.66% 70.66%
=======================================
Files 102 102
Lines 11585 11585
=======================================
Hits 8186 8186
Misses 3399 3399 |
jenshnielsen
force-pushed
the
docs/cleanup_logger
branch
2 times, most recently
from
0e83f59 to
d9dd8ff
Compare
jenshnielsen
force-pushed
the
docs/cleanup_logger
branch
from
741acef to
391bccc
Compare
Dominik-Vogel
approved these changes
Apr 3, 2019
Co-Authored-By: jenshnielsen <[email protected]>
giulioungaretti
pushed a commit
that referenced
this pull request
Apr 3, 2019
Merge: 8f450ae 0fe1716 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1517 from jenshnielsen/docs/cleanup_logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start working on improving the api docs for the logging modue