[DEM-831] Compiler warnings in ZIHDAWG8 should be logged or raised. #1522
Conversation
| for warning_as_error in self._warnings_as_errors: | ||
| if re.search(warning_as_error, warning) is not None: | ||
| raise CompilerError('Warning treated as an error.', warning) | ||
| log.warning(warning) |
There was a problem hiding this comment.
I suggest using the log attached to the instrument see https://qcodes.github.io/Qcodes/examples/Creating%20Instrument%20Drivers.html#Logging for more info
Codecov Report
@@ Coverage Diff @@
## master #1522 +/- ##
=======================================
Coverage 73.84% 73.84%
=======================================
Files 92 92
Lines 10459 10459
=======================================
Hits 7723 7723
Misses 2736 2736 |
|
I addressed the comment and tested the branch on hardware. Is there anything else I should do? |
There was a problem hiding this comment.
This in principle is OK-ish. Depending on how many people wanna use it.
I have two problems with this:
- filtering with regexp is absolutely not convenient in this case, and requires some effort to test/debug. i wish these warnings had "id" by which one could decide to throw an exception with it or not.
- if there are "errors", the only the first one is raised as an exception, and others are not included. I'd suggest that a more convenient way is to collect all "errors" and raise them as a single exception.
| ['compiler']['sourcestring'][0]) > 0: | ||
| time.sleep(0.1) | ||
| ['compiler']['sourcestring'][0]) > 0: | ||
| time.sleep(0.01) |
There was a problem hiding this comment.
please make at least a private attribute of the driver class out of this value.
| @@ -39,6 +53,19 @@ def __init__(self, name: str, device_id: str, **kwargs) -> None: | |||
| self.awg_module.execute() | |||
| node_tree = self.download_device_node_tree() | |||
| self.create_parameters_from_node_tree(node_tree) | |||
| self._warnings_as_errors: List[str] = [] | |||
|
|
|||
| def elevate_compiler_warning_to_error(self, *warnings: str) -> None: | |||
There was a problem hiding this comment.
since there is this "add" functionality, i'd expect also a function for "removing" an already added warning so that it's treated again as a warning, right?)
to make it even easier, instead of creating the "add" and "remove" functions, i'd just make the _warnings_as_errors list "public" and write smth in the docs or the example notebook on how to use it.
Filtering using regular expressions is needed as the status string has more info then just warnings. It is the output from the compiler and is only accessible as a single string. What type of "id" are you thinking about?
That I will do. |
|
@astafan8 I addressed the comments except the one with the error "ids". |
| if len(errors) > 0: | ||
| raise CompilerError('Warning treated as an error.', *errors) | ||
|
|
||
| [self.log.warning(warning) for warning in warnings] |
There was a problem hiding this comment.
sorry, and now it would be great as a user to get the "warning" warnings before the "error" warnings so that you get the "full compiler response", not just the "error" part in case there are "error" warnings. Fair wish? :)
|
I moved the logging of the warnings back into the for loop, but only log those that are not treated as errors. |
Merge: ebda0a8 6495a4a Author: Mikhail Astafev <[email protected]> Merge pull request #1522 from qutech-sd/feature/DEM-831/Compiler-warnings-should-be-caught
Changes proposed in this pull request:
@astafan8