Tektronix AWG 5014 : Fix range/validators of Channel offset, low pass filter, Marker high level and low level #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1626 +/- ##
=========================================
- Coverage 70.55% 66.55% -4%
=========================================
Files 123 140 +17
Lines 14921 17389 +2468
=========================================
+ Hits 10527 11573 +1046
- Misses 4394 5816 +1422 |
WilliamHPNielsen
changed the title
WilliamHPNielsen
suggested changes
Jul 12, 2019
There was a problem hiding this comment.
I suggest that we seize the opportunity to double check all the validators against the manual.
Edit: I don't think the manual actually lists the valid ranges. Then the validators should be checked against a real instrument. There is a very high probability that more parameters have incorrect validators.
Remove additional git syntax on the python file added automatically by git due to conflicting changes made.
lakhotiaharshit
changed the title
lakhotiaharshit
changed the title
|
@WilliamHPNielsen As we discussed. I validated the range of the parameters using a physical instrument. You were indeed right as I found 3 more incorrect validators. |
WilliamHPNielsen
approved these changes
Jul 17, 2019
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 17, 2019
Author: lakhotiaharshit <[email protected]> Tektronix AWG 5014 : Fix range/validators of Channel offset, low pass filter, Marker high level and low level (#1626)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrument: AWG5014
Fixed ranges
All the values were checked using a physical instrument.