Add clarity on JSON-ability of snapshot in docs #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
=======================================
Coverage 70.55% 70.55%
=======================================
Files 123 123
Lines 14921 14921
=======================================
Hits 10527 10527
Misses 4394 4394 |
giulioungaretti
pushed a commit
that referenced
this pull request
Jul 12, 2019
Merge: cb47310 cb9e398 Author: Jens Hedegaard Nielsen <[email protected]> Merge pull request #1627 from GateBuilder/jsonability_docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extra note concerning the involvement of a custom class about the JSON-ability of snapshots is added to the relevant docstrings.
@astafan8